fix: add ethers types to contracts-node and contracts-frontend #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <[email protected]>
Reinis-FRP
approved these changes
Jun 9, 2023
md0x
reviewed
Feb 26, 2024
There was a problem hiding this comment.
This fix would be useful!
This is how I was importing event types:
https://github.com/UMAprotocol/protocol/blob/master/packages/monitor-v2/src/monitor-polymarket/MonitorProposalsOrderBook.ts#L2
Do we want to add this changes @mrice32 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Importing ethers event types from contracts-node doesn't work.
Summary
You can now import ethers event types by doing the following:
Testing
Check a box to describe how you tested these changes and list the steps for reviewers to test.
Issue(s)
N/A